Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): TemplateParser.tryParse() returns both the AST and errors #7858

Closed
wants to merge 1 commit into from

Conversation

chuckjaz
Copy link
Contributor

Adds tryParse() to TemplateParser that always returns an AST even if there are errors.

  • What is the current behavior? (You can also link to an open issue here)

TemplateParser has a method parse() that throws when the template has errors.

  • What is the new behavior (if this is a feature change)?

TemplateParser as a method tryParse() that always returns an AST even if there are errors.

The language service (#7482) needs the AST even if there are errors.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

The language service (angular#7482) always needs the AST even if there are errors
in the template.
@mary-poppins
Copy link

Merging PR #7858 on behalf of @mhevery to branch presubmit-mhevery-pr-7858.

@mhevery mhevery closed this in 226e662 Apr 7, 2016
mircoba pushed a commit to mircoba/angular that referenced this pull request Apr 10, 2016
The language service (angular#7482) always needs the AST even if there are errors
in the template.

Closes angular#7858
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants