feat(i18n): add custom placeholder names #8057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kara
commented
Apr 14, 2016
kara
commented
- Please check if the PR fulfills these requirements
- The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
- Tests for the changes have been added (for bug fixes / features)
kara
added
the
action: review
kara
added
state: WIP
and removed
action: review
kara
added
action: review
| @@ -105,6 +105,9 @@ export function main() { | |||
|
|
|||
| it('should ignore comments in expressions', () => { checkAction('a //comment', 'a'); }); | |||
|
|
|||
| it('should retain // in quotes', | |||
|
Also, rename the second commit. The issue is not url specific. |
vsavkin
added
action: cleanup
kara
force-pushed
the
url
branch
2 times, most recently
from
4b0b6b9
to
ca30d95
Compare
kara
changed the title
kara
force-pushed
the
url
branch
2 times, most recently
from
dfde3da
to
aea83b9
Compare
kara
added
action: review
vsavkin
added
pr_state: LGTM
and removed
action: review
kara
changed the title
|
User @robertmesserle does not have PR merging privileges. |
|
Merging PR #8057 on behalf of @robertmesserle to branch presubmit-robertmesserle-pr-8057. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.