feat(core): separate refs from vars. #8264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
force-pushed
the
vars_refs
branch
2 times, most recently
from
72db404
to
90b13dc
Compare
| var identifier = bindParts[5]; | ||
| this._parseVariable(identifier, attrValue, attr.sourceSpan, targetVars); | ||
| } else if (isPresent(bindParts[2])) { // match: var-name / var-name="iden" | ||
| this._reportError(`"var-" is deprecated. Use "ref-" or "let-" instead!`, attr.sourceSpan, |
There was a problem hiding this comment.
Report the exact replacement, as we know it by checking the isTemplateElement flag
| @@ -30,7 +30,7 @@ import { | |||
| NgContentAst, | |||
| EmbeddedTemplateAst, | |||
| ElementAst, | |||
| VariableAst, | |||
| ReferenceAst, | |||
tbosch
added
pr_state: LGTM
action: cleanup
|
Reviewd in person with @mhevery |
tbosch
force-pushed
the
vars_refs
branch
2 times, most recently
from
41c9b14
to
e1eda7d
Compare
| } | ||
|
|
||
| /** | ||
| * A variable declaration on a <template> (e.g. `let var="expression"`). |
tbosch
force-pushed
the
vars_refs
branch
2 times, most recently
from
494a565
to
c1a4f20
Compare
| @@ -70,7 +70,7 @@ export abstract class ChangeDetectorRef { | |||
| * @Component({ | |||
| * selector: 'giant-list', | |||
| * template: ` | |||
| * <li *ngFor="#d of dataProvider.data">Data {{d}}</lig> | |||
| * <li *ngFor="let d of dataProvider.data">Data {{d}}</lig> | |||
Introduces `ref-` to give a name to an element or a directive (also works for `<template>` elements), and `let-` to introduce an input variable for a `<template>` element. BREAKING CHANGE: - `#...` now always means `ref-`. - `<template #abc>` now defines a reference to the TemplateRef, instead of an input variable used inside of the template. - `#...` inside of a *ngIf, … directives is deprecated. Use `let …` instead. - `var-...` is deprecated. Replace with `let-...` for `<template>` elements and `ref-` for non `<template>` elements. Closes angular#7158
tbosch
added
action: merge
|
Merging PR #8264 on behalf of @hansl to branch presubmit-hansl-pr-8264. |
This was referenced Apr 28, 2016
tbosch
added a commit
to tbosch/angular
that referenced
this pull request
Jun 7, 2016
Introduces `ref-` to give a name to an element or a directive (also works for `<template>` elements), and `let-` to introduce an input variable for a `<template>` element. BREAKING CHANGE: - `#...` now always means `ref-`. - `<template #abc>` now defines a reference to the TemplateRef, instead of an input variable used inside of the template. - `#...` inside of a *ngIf, … directives is deprecated. Use `let …` instead. - `var-...` is deprecated. Replace with `let-...` for `<template>` elements and `ref-` for non `<template>` elements. Closes angular#7158 Closes angular#8264
tbosch
added a commit
to tbosch/angular
that referenced
this pull request
Jun 15, 2016
Introduces `ref-` to give a name to an element or a directive (also works for `<template>` elements), and `let-` to introduce an input variable for a `<template>` element. BREAKING CHANGE: - `#...` now always means `ref-`. - `<template #abc>` now defines a reference to the TemplateRef, instead of an input variable used inside of the template. - `#...` inside of a *ngIf, … directives is deprecated. Use `let …` instead. - `var-...` is deprecated. Replace with `let-...` for `<template>` elements and `ref-` for non `<template>` elements. Closes angular#7158 Closes angular#8264
tbosch
added a commit
to tbosch/angular
that referenced
this pull request
Jun 24, 2016
Introduces `ref-` to give a name to an element or a directive (also works for `<template>` elements), and `let-` to introduce an input variable for a `<template>` element. BREAKING CHANGE: - `#...` now always means `ref-`. - `<template #abc>` now defines a reference to the TemplateRef, instead of an input variable used inside of the template. - `#...` inside of a *ngIf, … directives is deprecated. Use `let …` instead. - `var-...` is deprecated. Replace with `let-...` for `<template>` elements and `ref-` for non `<template>` elements. Closes angular#7158 Closes angular#8264
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not need to go into G3...