feat(ChangeDetectorRef): make detectChanges() correct

[lacolaco]

What is the current behavior? (You can also link to an open issue here)

ChangeDetectorRef.detectChanges() is skipped if it is detached.

What is the new behavior?

ChangeDetectorRef.detectChanges() executes detection even if it is detached.

Does this PR introduce a breaking change?
No

Other information:

Close #8597

[mhevery]

@vsavkin and @tbosch I would like to get your opinion on this

[tbosch]

A simpler solution would be this:
Move the check for ChangeDetectorMode.Detached into the loop where a parent view calls its children (i.e. AppView. detectContentChildrenChanges / AppView. detectViewChildrenChanges). Then ChangeDetectorRef.detectChanges() should works as expected.

[mhevery]

@laco0416 can you implement #8599 (comment) so that we can get this merged in?

[lacolaco]

Ok, I see. I'll do that.

[lacolaco]

@tbosch I've done. please review!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}