Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new router in rc.1 breaks when a url parameter contains a forward slash #8603

Closed
fctucker opened this issue May 11, 2016 · 5 comments
Closed

Comments

@fctucker
Copy link

fctucker commented May 11, 2016

Steps to reproduce and a minimal demo of the problem
Putting a slash in the url parameter causes the router and /or the page to break.

e.g. The following urls would not work when loading an angular2 app that uses @angular/router
localhost/home?some_param=someval/withaslash
or with matrix parameters
localhost/home;some_param=someval/withaslash

If the forward slash is escaped as %2f then it works fine. I remember this was an issue with the old router (now @angular/router-deprecated) but it was eventually fixed.

I have a workaround in place to escape the slashes, but it is hacky. It'd be nice if the new router could handle forward slashes in url or matrix parameters

Thanks!

@mhevery
Copy link
Contributor

mhevery commented May 13, 2016

Thank you for submitting the issue. All issues require a plunker which demonstrates the problem and how to reproduce it. Please re-open the issue or create a new issue once you have a reproducible use case.

We are sorry that we are so aggressive on closing the issues. We are overwhelmed with the number of issues we get, and so we only have time to look at the ones which are easy for us to reproduce.

@vsavkin
Copy link
Contributor

vsavkin commented Jun 24, 2016

Fixed #9581

@vsavkin vsavkin closed this as completed Jun 24, 2016
@Delagen
Copy link
Contributor

Delagen commented Jun 25, 2016

@vsavkin not work. Error: Cannot match any routes:

@digeomel
Copy link

I'm having this issue with Angular Router 7.2.14.
In fact, even though the parameter is escaped (%2F), I get a 400 error.
Is this a regression?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants