fix(UpgradeNg1ComponentAdapter): make bindings available on $scope #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… controller & link function Delays NG1 Directive controller instatiation where possible and pre-link function always to the ngOnInit() lifecycle hook. This way bindings are always available on $scope in both the controller and the link function.
hannahhoward
force-pushed
the
fix_upgrade_scope_8631
branch
from
53e9cc7
to
167c222
Compare
mhevery
added
pr_state: LGTM
action: merge
|
Great word @hannahhoward. I have scheduled to get this merged. |
|
awesome! I'll keep monitoring the community help list and see what I can do :) |
|
@hannahhoward would you be willing to take on #6655? |
KiaraGrouwstra
pushed a commit
to KiaraGrouwstra/angular
that referenced
this pull request
Jun 10, 2016
… controller & link function (angular#8645) Delays NG1 Directive controller instatiation where possible and pre-link function always to the ngOnInit() lifecycle hook. This way bindings are always available on $scope in both the controller and the link function.
KiaraGrouwstra
pushed a commit
to KiaraGrouwstra/angular
that referenced
this pull request
Jun 21, 2016
… controller & link function (angular#8645) Delays NG1 Directive controller instatiation where possible and pre-link function always to the ngOnInit() lifecycle hook. This way bindings are always available on $scope in both the controller and the link function.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8631
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
See #8631
What is the new behavior?
Currently, in an upgraded ng1 component, when controller constructor or link function is called, bindings are not available on $scope. This is because both functions where called early, before bindings had been passed down by NG2.
This PR delays NG1 Directive controller instatiation where possible and pre-link function always to the ngOnInit() lifecycle hook. This way bindings are always available on $scope in both the controller and the link function.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...