Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Reflector generates imports for '..' relative modules. #9004

Merged
merged 1 commit into from
Jun 3, 2016

Conversation

chuckjaz
Copy link
Contributor

@chuckjaz chuckjaz commented Jun 3, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
#9003

What is the new behavior?

The reflector host now generates imports for '..' relative modules.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:

Fixes #9003

@tbosch
Copy link
Contributor

tbosch commented Jun 3, 2016

Could you add a test? Either an integration test, or it would be nice to start a unit test for reflector_host

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 3, 2016
@chuckjaz
Copy link
Contributor Author

chuckjaz commented Jun 3, 2016

Making reflector_host.ts testable would be large than this PR. Submitting a issue to track making reflector_host.ts testable. #9005

@chuckjaz chuckjaz added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 3, 2016
@chuckjaz chuckjaz merged commit 35ea02f into angular:master Jun 3, 2016
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 10, 2016
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 21, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The offline-line compiler cannot generate references to '..' relative modules
3 participants