Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enableDebugTools import path #9377

Merged
merged 1 commit into from Jun 20, 2016
Merged

Fix enableDebugTools import path #9377

merged 1 commit into from Jun 20, 2016

Conversation

ulikoehler
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe:

Currently the JS tools example imports enableDebugTools from angular2/platform/browser. However, the package name has been changed, so enableDebugTools needs to be imported from @angular/platform-browser. I checked the new import path with 2.0.0-rc2 and can provide a Plunk if required.

There are no breaking changes as this is a doc-only fix.

Adapted to new @angular naming scheme.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ulikoehler
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@vicb
Copy link
Contributor

vicb commented Jun 20, 2016

The commit message follows our guidelines

Nope, I'll update before merging. Thanks for the PR.

@vicb vicb merged commit 8640534 into angular:master Jun 20, 2016
@ulikoehler ulikoehler deleted the patch-1 branch June 21, 2016 20:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants