[bug] RC.2 breaks @ViewChild to component thru forwardRef (recursive component structures)

[KiaraGrouwstra]

After this commit from RC2 ("set fixed @ViewChild / @ContentChild right after the view is created"), my @ViewChilds started breaking, erroring with:
Can't construct a query for the property <viewChildName> of <componentName> since the query selector wasn't defined.

Since I'm using recursive component structures, I have to use forwardRef to include the child components as directives into the host component. So what I have is like this:

@Component({
  directives: [ forwardRef(() => ChildComp) ]
})
class HostComp {
  @ViewChild(ChildComp) child: ChildComp;
}

The undefined selector here is the ChildComp argument of @ViewChild(ChildComp). If this forwardRef is not yet resolved here at the moment it's interpreting the ViewChild since RC2, then I guess it makes sense that it's coming up with an undefined selector.

I've yet to verify that with a minimal reproduction though. Plunker forthcoming -- I may need to await until my recent PR lands into the next RC. Anyway, posting this already in case anyone else has come across this error as well.

[ericmartinezr]

The error you're seeing comes from this fix #9018 for this issue #4489

[KiaraGrouwstra]

Thanks, that does look even more relevant.

[pkozlowski-opensource]

@tycho01 could you please share a minimal plunker (please use RC.3)? I'm surprised that it used to work, would like to confirm.

[vicb]

Would that work ?

class HostComp {
  @ViewChild(forwardRef(() => ChildComp)) child: ChildComp;

[pkozlowski-opensource]

Yep, forwardRef will work, so we've got an easy work-around: https://plnkr.co/edit/sbQ1lKL9YexoFVfYa7Cp?p=preview

I'm still very much surprised it used to work without forwardRef....

[KiaraGrouwstra]

Yeah, that seems to be helping. Thanks for the quick suggestions guys.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}