-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 2 RC 2 Hammer Gestures #9461
Comments
It is supported, please check playground/src/gestures. We should document it better /cc @wardbell |
Thank you so much @vicb for your reply. I just checked that, and the below file from playground/src/gestures suggests that we will have to include include Hammmer.js as its also including custom build of hammer. https://github.com/angular/angular/blob/master/modules/playground/src/gestures/index.html Please correct me if I am wrong. |
That was the case when the example was creating probably 1y+ ago because some fix commits were not released. I think they have been released since then. May be you can try to install the latest hammer.js and update the example. If this works, please submit a PR. Thanks. |
Yes, I tried that before opening the issue and if I include below script everything works.
Actually I thought that since its part of angular framework may be it could work without including hammmerjs |
If you want to update the example in a PR, please add hammerjs as a dev dependency in the package.json and use it from there. Thanks. |
I have added hammerjs to package.json. Can you please confirm the path which it should map too in live repository: On my device the following works:
|
Check /build.sh to create a link from node_modules in the playground/vendor folder You can then load the script from You can test by running build.sh and then got to /dist and run http-server (might need |
Close as too old. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Its not clear if the Hammer gestures are supported in Angular 2 RC 2 or not.
From the API we can see
under
@angular/platform-browser
( https://angular.io/docs/ts/latest/api/#!?apiFilter=hammer )
But its not clear how to use it, some posts on internet suggest including hammer.js but if its a part of API I believe one would expect to use it without any external dependency.
The text was updated successfully, but these errors were encountered: