-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UrlMatcher should be exported or removed from the API docs #15140
Comments
I'm marking this as a candidate for 4.0.0 because it's an easy fix and currently results in issues in our docs infrastructure. // @vicb |
I don't see this anymore in the API docs @IgorMinar . Should we close or ... ? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a ... (check one with "x")
Current behavior
The Router interface uses
UrlMatcher
andUrlMatcher
is not exported.Expected behavior
The
UrlMatcher
should be exported as well. We have documentation for it but leads to a 404.What is the motivation / use case for changing the behavior?
I am a member of the docs team and we get an issue every other week about the
UrlMatcher
link here leading to a 404.There are a few issues in this repo, a few issues on aio repo. I decided to investigate the issue with @petebacondarwin to see if that was a dgeni issue and we discovered (well, he did) that dgeni is not parsing out the
UrlMatcher
documentation which exist here because at the end, theUrlMatcher
is not exported with the barrel.I am in no position to assert that it should be public or not, but we can't document it otherwise, so it would be better to decide in make it public or remove the link from the API since we cannot document it (and I think we shouldn't if it is not public).
The text was updated successfully, but these errors were encountered: