Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: remove dead tests from AppComponent #15593

Closed
petebacondarwin opened this issue Mar 29, 2017 · 5 comments · Fixed by #16590
Closed

aio: remove dead tests from AppComponent #15593

petebacondarwin opened this issue Mar 29, 2017 · 5 comments · Fixed by #16590

Comments

@petebacondarwin
Copy link
Member

petebacondarwin commented Mar 29, 2017 •
edited

See #15570 (comment) and #15570 (comment)
@petebacondarwin petebacondarwin changed the title aio: remove dead test from AppComponent aio: remove dead tests from AppComponent Mar 29, 2017
@petebacondarwin petebacondarwin added this to TODO in docs-infra Mar 29, 2017
@wardbell
Copy link
Contributor

I think I did this, Pete. Reopen if I'm wrong.

@petebacondarwin
Copy link
Member Author

This test is still there: https://github.com/angular/angular/blob/master/aio/src/app/app.component.spec.ts#L285-L291

@wardbell
Copy link
Contributor

That is a VALID TEST

@petebacondarwin
Copy link
Member Author

The lines have moved. The test to remove is the search worker initialization one

petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 5, 2017
@petebacondarwin
refactor(aio): remove redundant test
c734e80 
The search worker is now initialised from the `SearchBoxComponent`, which
has its own tests for this.

Closes angular#15593
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 5, 2017
@petebacondarwin
refactor(aio): remove redundant test
a319182 
The search worker is now initialised from the `SearchBoxComponent`, which
has its own tests for this.

Closes angular#15593
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 5, 2017
@petebacondarwin
refactor(aio): remove redundant test
0721551 
The search worker is now initialised from the `SearchBoxComponent`, which
has its own tests for this.

Closes angular#15593
@petebacondarwin petebacondarwin mentioned this issue May 5, 2017
Merged
matsko pushed a commit that referenced this issue May 5, 2017
@petebacondarwin @matsko
refactor(aio): remove redundant test
42dc2c1 
The search worker is now initialised from the `SearchBoxComponent`, which
has its own tests for this.

Closes #15593
@petebacondarwin petebacondarwin removed this from TODO in docs-infra May 8, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@petebacondarwin
refactor(aio): remove redundant test
cbf08a1 
The search worker is now initialised from the `SearchBoxComponent`, which
has its own tests for this.

Closes angular#15593
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@petebacondarwin @juleskremer
refactor(aio): remove redundant test
148d81f 
The search worker is now initialised from the `SearchBoxComponent`, which
has its own tests for this.

Closes angular#15593
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(aio): remove redundant test petebacondarwin/angular
2 participants
@petebacondarwin @wardbell