Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: heading anchor styling has broken other links inside headings #16573

Closed
petebacondarwin opened this issue May 5, 2017 · 1 comment · Fixed by #16599
Closed

aio: heading anchor styling has broken other links inside headings #16573

petebacondarwin opened this issue May 5, 2017 · 1 comment · Fixed by #16599
Assignees
@sjtrimble
Labels
type: bug/fix

Comments

@petebacondarwin
Copy link
Member

Some docs include a link inside their heading (e.g. live-server). See
screen shot 2017-05-05 at 10 47 45

We need to include the heading-anchor class on the styling of heading anchors to ensure that it doesn't break other links.
@petebacondarwin petebacondarwin added this to TODO Blockers in docs-infra May 5, 2017
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 6, 2017
@petebacondarwin
fix(aio): constrain header-link styles
940e475 
The CSS rule for positioning the automated header links was too general,
causing other links inside headings to be positioned incorrectly.

Closes angular#16573
@petebacondarwin petebacondarwin mentioned this issue May 6, 2017
Merged
petebacondarwin added a commit that referenced this issue May 6, 2017
@petebacondarwin
fix(aio): constrain header-link styles
03513e9 
The CSS rule for positioning the automated header links was too general,
causing other links inside headings to be positioned incorrectly.

Closes #16573
@petebacondarwin petebacondarwin removed this from TODO Blockers in docs-infra May 6, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@petebacondarwin
fix(aio): constrain header-link styles
5a09d95 
The CSS rule for positioning the automated header links was too general,
causing other links inside headings to be positioned incorrectly.

Closes angular#16573
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@petebacondarwin @juleskremer
fix(aio): constrain header-link styles
b8e0377 
The CSS rule for positioning the automated header links was too general,
causing other links inside headings to be positioned incorrectly.

Closes angular#16573
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sjtrimble sjtrimble

Labels
type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aio): constrain header-link styles petebacondarwin/angular
2 participants
@petebacondarwin @sjtrimble