Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: floating ToC - flash of unwanted "Contents" #16597

Closed
petebacondarwin opened this issue May 6, 2017 · 1 comment · Fixed by #16598
Closed

aio: floating ToC - flash of unwanted "Contents" #16597

petebacondarwin opened this issue May 6, 2017 · 1 comment · Fixed by #16598
Labels
type: bug/fix

Comments

@petebacondarwin
Copy link
Member

If you go to a page that will not have a ToC, there is an initial flash of the word "Contents" in the right hand panel before being removed.
@petebacondarwin petebacondarwin added this to TODO Blockers in docs-infra May 6, 2017
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 6, 2017
@petebacondarwin
fix(aio): do not display a Toc initially
021fca5 
Previously the `hasToc` was initialised to true, which caused a flash of
unwanted "Contents" [sic] even if the page was not going to need a ToC.

Closes angular#16597
@petebacondarwin petebacondarwin mentioned this issue May 6, 2017
Merged
petebacondarwin added a commit that referenced this issue May 6, 2017
@petebacondarwin
fix(aio): do not display a Toc initially
b9ed97c 
Previously the `hasToc` was initialised to true, which caused a flash of
unwanted "Contents" [sic] even if the page was not going to need a ToC.

Closes #16597
@petebacondarwin petebacondarwin removed this from TODO Blockers in docs-infra May 6, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@petebacondarwin
fix(aio): do not display a Toc initially
b835f23 
Previously the `hasToc` was initialised to true, which caused a flash of
unwanted "Contents" [sic] even if the page was not going to need a ToC.

Closes angular#16597
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@petebacondarwin @juleskremer
fix(aio): do not display a Toc initially
c11dca1 
Previously the `hasToc` was initialised to true, which caused a flash of
unwanted "Contents" [sic] even if the page was not going to need a ToC.

Closes angular#16597
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aio): do not display a Toc initially petebacondarwin/angular
1 participant
@petebacondarwin