Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: sweep and fix images that are not displaying correctly #16600

Closed
petebacondarwin opened this issue May 6, 2017 · 1 comment
Closed

aio: sweep and fix images that are not displaying correctly #16600

petebacondarwin opened this issue May 6, 2017 · 1 comment
Assignees
@wardbell @Foxandxss
Labels
type: bug/fix

Comments

@petebacondarwin
Copy link
Member

All images are now being automatically assigned width and height attributes.
This is causing some display problems where CSS styles (either inline or implicit from rules) are causing the images to be display incorrectly. E.g. The styling is changing the width but not the height and so the image is becoming stretched, or if an SVG it is getting extra unwanted padding.

We need to sweep the docs for all the images and check that they are all rendering correctly.
@petebacondarwin petebacondarwin added this to TODO Blockers in docs-infra May 6, 2017
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 6, 2017
@petebacondarwin
docs(aio): fix sizing of marketing doc images
ec59ca8 
This commit ensures that all the images in the marketing docs are correcly
sized.

Related to angular#16600
@petebacondarwin petebacondarwin mentioned this issue May 6, 2017
Merged
petebacondarwin added a commit that referenced this issue May 6, 2017
@petebacondarwin
docs(aio): fix sizing of marketing doc images
5cf6426 
This commit ensures that all the images in the marketing docs are correcly
sized.

Related to #16600
@petebacondarwin petebacondarwin moved this from TODO Blockers to WIP in docs-infra May 6, 2017
@petebacondarwin petebacondarwin moved this from WIP to REVIEW in docs-infra May 9, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra May 9, 2017
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra May 9, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@petebacondarwin
docs(aio): fix sizing of marketing doc images
9571668 
This commit ensures that all the images in the marketing docs are correcly
sized.

Related to angular#16600
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@petebacondarwin @juleskremer
docs(aio): fix sizing of marketing doc images
213466a 
This commit ensures that all the images in the marketing docs are correcly
sized.

Related to angular#16600
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wardbell wardbell

@Foxandxss Foxandxss

Labels
type: bug/fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petebacondarwin @wardbell @Foxandxss