Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aio: option to blow away the service worker #16897

Closed
petebacondarwin opened this issue May 19, 2017 · 3 comments · Fixed by #17032
Closed

aio: option to blow away the service worker #16897

petebacondarwin opened this issue May 19, 2017 · 3 comments · Fixed by #17032

Comments

@petebacondarwin
Copy link
Member

No description provided.

@petebacondarwin petebacondarwin created this issue from a note in docs-infra (TODO Blockers) May 19, 2017
@petebacondarwin
Copy link
Member Author

petebacondarwin commented May 22, 2017

This might be useful reading: http://stackoverflow.com/questions/33986976/how-can-i-remove-a-buggy-service-worker-or-implement-a-kill-switch which also links to this information http://stackoverflow.com/questions/38843970/service-worker-javascript-update-frequency-every-24-hours/38854905#38854905

The long and the short of it is that we can replace the service-worker.js on our server at any time and browser will update to this new file at the point the user navigates to our site with the following caching restriction: the old service-worker.js file will be cached for either the length of time specified in the caching headers or 24 hours, whichever is shorter.

So the only thing we need to do right now is:

a) set our caching period to a length of time <24 hours that we deem as appropriate. I suggest 60 mins.
b) create a noop-service-worker.js file that we can apply quickly in an emergency that effectively disables the service worker.

@petebacondarwin
Copy link
Member Author

a) The default cache time for Firebase files is 3600 sec, so the worker-basic.min.js is already set to expire every hour.

petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 26, 2017
Use this file if we need to turn off the service worker in deployed sites
in an emergency where the worker has a bug that is blocking the application
from working.

Closes angular#16897
@petebacondarwin petebacondarwin moved this from TODO Blockers to REVIEW in docs-infra May 26, 2017
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 26, 2017
Use this file if we need to turn off the service worker in deployed sites
in an emergency where the worker has a bug that is blocking the application
from working.

Closes angular#16897
@petebacondarwin petebacondarwin removed this from REVIEW in docs-infra May 26, 2017
petebacondarwin added a commit that referenced this issue May 26, 2017
Use this file if we need to turn off the service worker in deployed sites
in an emergency where the worker has a bug that is blocking the application
from working.

Closes #16897
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
Use this file if we need to turn off the service worker in deployed sites
in an emergency where the worker has a bug that is blocking the application
from working.

Closes angular#16897
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
Use this file if we need to turn off the service worker in deployed sites
in an emergency where the worker has a bug that is blocking the application
from working.

Closes angular#16897
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant