Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial - Upgrade AngularJS to Angular Typescript npm script is missing #17093

Closed
ido-ran opened this issue May 30, 2017 · 4 comments · Fixed by #17100
Closed

Tutorial - Upgrade AngularJS to Angular Typescript npm script is missing #17093

ido-ran opened this issue May 30, 2017 · 4 comments · Fixed by #17100

Comments

@ido-ran
Copy link

ido-ran commented May 30, 2017

I'm submitting a ... (check one with "x")

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
In the upgrade tutorial at Switching to Typescript step the code for changing package.json to include tsc:w script is missing.

This is how it looks like in my browser:
image

Expected behavior
I guess the example json should look something like this:

{
  "scripts": {
     "tsc": "tsc",
    "tsc:w": "tsc -w"
   }
}

Because few paragraph bellow this command should be run npm run tsc:w.

Please tell us about your environment:

Windows 10.
@gkalpak
Copy link
Member

gkalpak commented May 30, 2017

This section has been slightly reworked (and this isn't an issue any more) in the new (soon-to-be-released) version.

@gkalpak gkalpak closed this as completed May 30, 2017
@ido-ran
Copy link
Author

ido-ran commented May 30, 2017

Hi,
I'm looking at the new docs but I still don't see the definition for tsc:w in package.json.
Also search for

to also point to the project root instead of

It looks like it is missing code example too.

@gkalpak
Copy link
Member

gkalpak commented May 30, 2017

Fair enough 😃

@gkalpak gkalpak reopened this May 30, 2017
gkalpak added a commit to gkalpak/angular that referenced this issue May 30, 2017
@gkalpak
docs(aio): minor fixes for the upgrade guide
467be63 
Fixes angular#17093
@gkalpak gkalpak mentioned this issue May 30, 2017
Merged
@vicb vicb added the comp: aio label May 30, 2017
@petebacondarwin petebacondarwin added this to Content Only in docs-infra Jun 9, 2017
@wardbell wardbell removed this from Content Only in docs-infra Jun 21, 2017
@wardbell wardbell added this to TODO in docs Jun 21, 2017
matsko pushed a commit that referenced this issue Jun 23, 2017
@gkalpak @matsko
docs(aio): minor fixes for the upgrade guide
8b4acbb 
Fixes #17093
matsko pushed a commit that referenced this issue Jun 23, 2017
@gkalpak @matsko
docs(aio): minor fixes for the upgrade guide
1657fa7 
Fixes #17093
@wardbell wardbell removed this from TODO in docs Jun 23, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@gkalpak
docs(aio): minor fixes for the upgrade guide
86081ba 
Fixes angular#17093
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@gkalpak @juleskremer
docs(aio): minor fixes for the upgrade guide
332ecbc 
Fixes angular#17093
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(aio): minor fixes for the upgrade guide gkalpak/angular
4 participants
@wardbell @ido-ran @vicb @gkalpak