Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: console.log for every doc navigation in production #17453

Closed
fredrik-lundin opened this issue Jun 13, 2017 · 3 comments · Fixed by #17508
Closed

aio: console.log for every doc navigation in production #17453

fredrik-lundin opened this issue Jun 13, 2017 · 3 comments · Fixed by #17508
Assignees
@gkalpak

Comments

@fredrik-lundin
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
When navigating around the new angular.io docs, each navigation gets printed to the developer console

Expected behavior
This should not be logged in production (I guess?)

Minimal reproduction of the problem with instructions

  1. Go to https://angular.io/docs
  2. Open developer console in your browser
  3. Navigate between pages

aio-console-log

What is the motivation / use case for changing the behavior?
It just looks like a strange behavior for a production build

Please tell us about your environment:

  • Windows 7

AIO version:

  • angular.io build: Version 4.2.3-build.31653+sha.dc084a5.

Browser:

  • Chrome (Version 58.0.3029.110 (64-bit))
  • Internet Explorer 11 (version 11.0.42)
  • Firefox 52.1.2 (32-bit)
@gkalpak gkalpak assigned gkalpak and unassigned gkalpak Jun 13, 2017
@gkalpak gkalpak added this to TODO Blockers in docs-infra Jun 13, 2017
@petebacondarwin
Copy link
Member

Let's remove these.

@gkalpak gkalpak assigned gkalpak and unassigned gkalpak Jun 13, 2017
@IgorMinar
Copy link
Contributor

yeah. that's fine. let's remove.

@gkalpak gkalpak self-assigned this Jun 14, 2017
gkalpak added a commit to gkalpak/angular that referenced this issue Jun 14, 2017
@gkalpak
fix(aio): do not log messages in production
aa4a90e 
In dev mode, all messages passed to `Logger` will be logged.
In production mode, only warnings and errors will be logged.

Fixes angular#17453
@gkalpak gkalpak mentioned this issue Jun 14, 2017
Merged
petebacondarwin pushed a commit that referenced this issue Jun 15, 2017
@gkalpak @petebacondarwin
fix(aio): do not log messages in production
01173b9 
In dev mode, all messages passed to `Logger` will be logged.
In production mode, only warnings and errors will be logged.

Fixes #17453
@petebacondarwin petebacondarwin removed this from TODO Blockers in docs-infra Jun 15, 2017
petebacondarwin pushed a commit that referenced this issue Jun 15, 2017
@gkalpak @petebacondarwin
fix(aio): do not log messages in production
ab90f63 
In dev mode, all messages passed to `Logger` will be logged.
In production mode, only warnings and errors will be logged.

Fixes #17453
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@gkalpak
fix(aio): do not log messages in production
8625ba7 
In dev mode, all messages passed to `Logger` will be logged.
In production mode, only warnings and errors will be logged.

Fixes angular#17453
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@gkalpak @juleskremer
fix(aio): do not log messages in production
fff0e51 
In dev mode, all messages passed to `Logger` will be logged.
In production mode, only warnings and errors will be logged.

Fixes angular#17453
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkalpak gkalpak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aio): do not log messages in production gkalpak/angular
4 participants
@petebacondarwin @IgorMinar @fredrik-lundin @gkalpak