Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Regression between 4.2.0-rc.1 and 4.2.0-rc.2 - Still here in 4.2.4 #17746

Closed
toniopelo opened this issue Jun 24, 2017 · 3 comments · Fixed by #17777
Closed

Animation Regression between 4.2.0-rc.1 and 4.2.0-rc.2 - Still here in 4.2.4 #17746

toniopelo opened this issue Jun 24, 2017 · 3 comments · Fixed by #17777
Assignees
Labels
area: animations regression Indicates than the issue relates to something that worked in a previous version

Comments

@toniopelo
Copy link

toniopelo commented Jun 24, 2017

I'm submitting a Regression


[x] Regression (behavior that used to work and stopped working in a new release)
[ ] Bug report 
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

One animation just doesn't appear. Difficult to explain, better see on the plunker provided after.
You will see that the blue and red block that are coming above the grey one on route change and are supposed to go backward on next route change just disappear on v4.2.0-rc.2 and above.
Explainations are on the plunker

Expected behavior

The animation should display as it does with Angular v4.2.0-rc.1

Minimal reproduction of the problem with instructions

See this plunker: https://plnkr.co/edit/0xYfsX7Z2RQyZGmNgPOw?p=preview
Just change the version from 4.2.0-rc.1 to 4.2.0-rc.2 or higher to see the difference in the animations.

What is the motivation / use case for changing the behavior?

Make it work :D

Please tell us about your environment


Angular version: 4.2.4


Browser:
- [x] Chromium (desktop) version 58.0.3029.110
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: v7.10.0
- Platform: Linux

Maybe there is something to do with this issue #17170
Both regressions appeared on the same time apparently.

Thanks for your help and have a nice day!

@matsko matsko added area: animations regression Indicates than the issue relates to something that worked in a previous version labels Jun 26, 2017
@matsko matsko self-assigned this Jun 26, 2017
matsko added a commit to matsko/angular that referenced this issue Jun 27, 2017
@matsko
Copy link
Contributor

matsko commented Jun 27, 2017

Excellent find. We now have a proper fix #17777

matsko added a commit to matsko/angular that referenced this issue Jun 27, 2017
@toniopelo
Copy link
Author

Thanks! When can we expect this to be released ?

matsko added a commit that referenced this issue Jun 27, 2017
matsko added a commit to matsko/angular that referenced this issue Jun 29, 2017
matsko added a commit that referenced this issue Jun 30, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: animations regression Indicates than the issue relates to something that worked in a previous version
Projects
None yet
2 participants