Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading typo in Benchpress ReadMe #23471

Closed
PaulTFreedman opened this issue Apr 20, 2018 · 2 comments
Closed

Misleading typo in Benchpress ReadMe #23471

PaulTFreedman opened this issue Apr 20, 2018 · 2 comments
Labels
area: benchpress
Milestone
needsTriage

Comments

@PaulTFreedman
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[X] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Under Measuring in the browser the names used indicate that the loop iterates 10,000 times but it actually iterates 100,000 times. It's a minor issue but for the sake of clarity it's worth correcting.

Expected behavior

Iterate 10,000 times.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

To increase clarity of example.

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:
@ngbot ngbot bot added this to the needsTriage milestone Apr 20, 2018
@vicb
Copy link
Contributor

vicb commented Apr 20, 2018

@PaulTFreedman would you like to send a PR ?

PaulTFreedman added a commit to PaulTFreedman/angular that referenced this issue Apr 21, 2018
@PaulTFreedman
docs(benchpress): fix typo in README (angular#23471)
92287d6
@PaulTFreedman PaulTFreedman mentioned this issue Apr 21, 2018
Closed
3 tasks
vicb pushed a commit that referenced this issue Apr 24, 2018
@PaulTFreedman @vicb
docs(benchpress): fix typo in README (#23471) (#23488)
811a7f2 
PR Close #23488
vicb pushed a commit that referenced this issue Apr 24, 2018
@PaulTFreedman @vicb
docs(benchpress): fix typo in README (#23471) (#23488)
1b26dd8 
PR Close #23488
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: benchpress
Projects
None yet
Milestone
needsTriage
Development

No branches or pull requests
2 participants
@vicb @PaulTFreedman