Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http): EventEmitter and Dart support #2415

Closed
jeffbcross opened this issue Jun 8, 2015 · 3 comments
Closed

feat(http): EventEmitter and Dart support #2415

jeffbcross opened this issue Jun 8, 2015 · 3 comments
Assignees
@jeffbcross
Labels
effort2: days feature Issue that requests a new feature
Milestone
alpha-29

Comments

@jeffbcross
Copy link
Contributor

The initial implementation of http (PR #2360) is only tested in JS, and is limited to JavaScript because it's using RxJS directly. The library should be changed to use the EventEmitter abstraction, which uses RxJS for JavaScript, and streams for dart. This will require extending EventEmitter to support creation of cold observable, and to support the map operator.
@jeffbcross jeffbcross added feature Issue that requests a new feature comp: data-access effort2: days labels Jun 8, 2015
@jeffbcross jeffbcross self-assigned this Jun 8, 2015
@jeffbcross jeffbcross added this to the M10 milestone Jun 8, 2015
@PatrickJS
Copy link
Member

it sounds like we need an EventEmitterWrapper

@jeffbcross jeffbcross mentioned this issue Jun 9, 2015
Closed
@jeffbcross
Copy link
Contributor Author

@gdi2290 our thinking is that we'll use the ObservableWrapper for creation and combinators (in addition to subscription, which it already does).

@mhevery mhevery modified the milestones: alpha-28, alpha-27 Jun 12, 2015
@jeffbcross jeffbcross modified the milestones: alpha-29, alpha-28 Jun 19, 2015
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jun 24, 2015
@jeffbcross
feat(http): refactor library to work in dart
8ebbebb 
Mostly internal refactoring needed to make ts2dart and DartAnalyzer happy.

Fixes angular#2415
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jun 26, 2015
@jeffbcross
feat(http): refactor library to work in dart
71102fd 
Mostly internal refactoring needed to make ts2dart and DartAnalyzer happy.

Fixes angular#2415
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jun 30, 2015
@jeffbcross
feat(http): refactor library to work in dart
1de8d99 
Mostly internal refactoring needed to make ts2dart and DartAnalyzer happy.

Fixes angular#2415
@jeffbcross jeffbcross mentioned this issue Jun 30, 2015
Closed
35 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffbcross jeffbcross

Labels
effort2: days feature Issue that requests a new feature
Projects
None yet
Milestone
alpha-29
Development

No branches or pull requests
3 participants
@mhevery @jeffbcross @PatrickJS