Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DART transformers] Add support for styles and styleUrls in Directive #2566

Closed
vicb opened this issue Jun 16, 2015 · 3 comments
Closed

[DART transformers] Add support for styles and styleUrls in Directive #2566

vicb opened this issue Jun 16, 2015 · 3 comments
Assignees
@jakemac53
Labels
feature Issue that requests a new feature
Milestone
alpha-28

Comments

@vicb
Copy link
Contributor

vicb commented Jun 16, 2015

/ref #2459 #2563

Two new properties have been introduced for Directive:

  • styles: a list of css text
  • styleUrls: a list of css urls

The template loader has been modified to resolved the url in the css and inline @import rules (this was previously done by the shadow dom strategies).

I'm not exactly sure what is left to be done in the transformers as they use the TemplateLoader.
@vicb vicb added feature Issue that requests a new feature comp: dart-transformer labels Jun 16, 2015
@naomiblack naomiblack added this to the alpha-28 milestone Jun 17, 2015
@naomiblack
Copy link
Contributor

@jakemac53 can you have a look at this one? we're hoping it's a straightforward fix at the transformer level.

@jakemac53
Copy link
Contributor

can do

TedSander pushed a commit to TedSander/angular that referenced this issue Jun 17, 2015
feat(transformers): inline styleUrls to view directive
229878f 
While creating the ng_deps.dart file for a view inline the styleUrls attribute.
This copies the pattern used for templateUrl, aleviating the need to make an
XHR request for those resources.

closes angular#2566
@TedSander TedSander mentioned this issue Jun 17, 2015
Closed
TedSander pushed a commit to TedSander/angular that referenced this issue Jun 17, 2015
@TedSander
feat(transformers): inline styleUrls to view directive
6cc3fe0 
While creating the ng_deps.dart file for a view inline the styleUrls attribute.
This copies the pattern used for templateUrl, aleviating the need to make an
XHR request for those resources.

closes angular#2566
TedSander pushed a commit to TedSander/angular that referenced this issue Jun 17, 2015
@TedSander
feat(transformers): inline styleUrls to view directive
ad19b44 
While creating the ng_deps.dart file for a view inline the styleUrls attribute.
This copies the pattern used for templateUrl, aleviating the need to make an
XHR request for those resources.

closes angular#2566
TedSander pushed a commit to TedSander/angular that referenced this issue Jun 17, 2015
@TedSander
feat(transformers): inline styleUrls to view directive
f25b8e6 
While creating the ng_deps.dart file for a view inline the styleUrls attribute.
This copies the pattern used for templateUrl, aleviating the need to make an
XHR request for those resources.

closes angular#2566
TedSander pushed a commit to TedSander/angular that referenced this issue Jun 18, 2015
@TedSander
feat(transformers): inline styleUrls to view directive
0c2a758 
While creating the ng_deps.dart file for a view inline the styleUrls attribute.
This copies the pattern used for templateUrl, aleviating the need to make an
XHR request for those resources.

closes angular#2566
TedSander pushed a commit to TedSander/angular that referenced this issue Jun 18, 2015
@TedSander
feat(transformers): inline styleUrls to view directive
62604fe 
While creating the ng_deps.dart file for a view inline the styleUrls attribute.
This copies the pattern used for templateUrl, aleviating the need to make an
XHR request for those resources.

closes angular#2566
@rkirov rkirov closed this as completed in f2ef90b Jun 19, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakemac53 jakemac53

Labels
feature Issue that requests a new feature
Projects
None yet
Milestone
alpha-28
Development

No branches or pull requests
3 participants
@vicb @jakemac53 @naomiblack