Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated angular2.d.ts fails DefinitelyTyped tests #2686

Closed
alexeagle opened this issue Jun 22, 2015 · 3 comments
Closed

Generated angular2.d.ts fails DefinitelyTyped tests #2686

alexeagle opened this issue Jun 22, 2015 · 3 comments
Assignees
@alexeagle
Labels
area: build & ci Related the build and CI infrastructure of the project effort2: days feature Issue that requests a new feature

Comments

@alexeagle
Copy link
Contributor

in DefinitelyTyped, there is an existing build and test scheme. In prior releases of our angular2.d.ts I've had to manually work around some things:

  • dgeni includes the generic type parameter as a member (eg. classes start with T;)
  • TS 1.4: destructured args have to be rewritten as a named interface
  • TS 1.4: change const to var
  • comply with noImplicitAny: add return types and type missing stuff as any

note that DT should start accepting TS 1.5 after the official release: see DefinitelyTyped/DefinitelyTyped#4564
@alexeagle alexeagle self-assigned this Jun 22, 2015
@alexeagle
Copy link
Contributor Author

FYI @dariajung

@jeffbcross jeffbcross mentioned this issue Jun 22, 2015
Closed
alexeagle added a commit to alexeagle/angular that referenced this issue Jun 25, 2015
@alexeagle
fix(typings): Minor issues preventing angular2.d.ts from working in T…
51763cb 
…S 1.4.

This removes some, but not all, of the manual work needed to patch up our
.d.ts for pushing to DefinitelyTyped. Remaining manual steps are:
- some types still missing
- declaration of decorators
- remove destructuring args

See angular#2686.
@alexeagle alexeagle mentioned this issue Jun 25, 2015
Closed
alexeagle added a commit that referenced this issue Jun 25, 2015
@alexeagle
fix(typings): Minor issues preventing angular2.d.ts from working in T…
7a4a3c8 
…S 1.4.

This removes some, but not all, of the manual work needed to patch up our
.d.ts for pushing to DefinitelyTyped. Remaining manual steps are:
- some types still missing
- declaration of decorators
- remove destructuring args

See #2686.
jimthedev pushed a commit to jimthedev/angular that referenced this issue Jun 30, 2015
@alexeagle @jimthedev
fix(typings): Minor issues preventing angular2.d.ts from working in T…
4b0fa65 
…S 1.4.

This removes some, but not all, of the manual work needed to patch up our
.d.ts for pushing to DefinitelyTyped. Remaining manual steps are:
- some types still missing
- declaration of decorators
- remove destructuring args

See angular#2686.
jimthedev pushed a commit to jimthedev/angular that referenced this issue Jun 30, 2015
@alexeagle @jimthedev
fix(typings): Minor issues preventing angular2.d.ts from working in T…
b8b8af5 
…S 1.4.

This removes some, but not all, of the manual work needed to patch up our
.d.ts for pushing to DefinitelyTyped. Remaining manual steps are:
- some types still missing
- declaration of decorators
- remove destructuring args

See angular#2686.
@mhevery mhevery added feature Issue that requests a new feature area: build & ci Related the build and CI infrastructure of the project P2: required effort2: days labels Jun 30, 2015
@alexeagle
Copy link
Contributor Author

This has been fixed following TS 1.5 release.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexeagle alexeagle

Labels
area: build & ci Related the build and CI infrastructure of the project effort2: days feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @mhevery