Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Much of the public API lacks types on method parameters #2833

Closed
alexeagle opened this issue Jul 1, 2015 · 2 comments
Closed

Much of the public API lacks types on method parameters #2833

alexeagle opened this issue Jul 1, 2015 · 2 comments
Assignees
@alexeagle
Labels
area: build & ci Related the build and CI infrastructure of the project effort1: hours
Milestone
alpha-32

Comments

@alexeagle
Copy link
Contributor

Similar to work in #2746 which handles return types.
We should add a tslint check that our public API methods declare the types of their parameters.
This is important for consumers like the angular2.d.ts and Dart API docs, which otherwise show these as any/dynamic
@alexeagle alexeagle added area: build & ci Related the build and CI infrastructure of the project type: chore effort1: hours labels Jul 1, 2015
@alexeagle alexeagle added this to the alpha-31 milestone Jul 1, 2015
@naomiblack naomiblack modified the milestones: alpha-32, alpha-31 Jul 6, 2015
@mhevery
Copy link
Contributor

mhevery commented Jul 7, 2015

👍

alexeagle added a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@alexeagle
feat(build): require parameter types
677f2b3 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@alexeagle
feat(build): require parameter types
4a33509 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@alexeagle
feat(build): require parameter types
30810e3 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@alexeagle
feat(build): require parameter types
486be28 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@alexeagle
feat(build): require parameter types
1a0844f 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@alexeagle
feat(build): require parameter types
a28110c 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@alexeagle
feat(build): require parameter types
463df36 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 20, 2015
@alexeagle
feat(build): require parameter types
eb8de2f 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 20, 2015
@alexeagle
feat(build): require parameter types
6e516a0 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 20, 2015
@alexeagle
feat(build): require parameter types
e9bfd8a 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 20, 2015
@alexeagle
feat(build): require parameter types
5eed970 
Fixes angular#2833
alexeagle added a commit to alexeagle/angular that referenced this issue Jul 20, 2015
@alexeagle
feat(build): require parameter types
b479df7 
Fixes angular#2833
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexeagle alexeagle

Labels
area: build & ci Related the build and CI infrastructure of the project effort1: hours
Projects
None yet
Milestone
alpha-32
Development

No branches or pull requests
3 participants
@alexeagle @mhevery @naomiblack