Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tsc should not let public methods require parameters/return values of a private type during build #3098

Closed
uber5001 opened this issue Jul 16, 2015 · 2 comments
Closed

Tsc should not let public methods require parameters/return values of a private type during build #3098

uber5001 opened this issue Jul 16, 2015 · 2 comments
Assignees
@alexeagle

Comments

@uber5001
Copy link
Contributor

When running tsc manually against the sources in modules/angular2, these errors are given:

src/change_detection/parser/lexer.ts(35,50): error TS4063: Parameter 'type' of constructor from exported class has or is using private name 'TokenType'.
src/directives/ng_for.ts(94,34): error TS4070: Parameter 'tuples' of public static method from exported class has or is using private name 'RecordViewTuple'.
src/directives/ng_for.ts(95,60): error TS4052: Return type of public static method from exported class has or is using private name 'RecordViewTuple'.
src/directives/ng_for.ts(111,34): error TS4070: Parameter 'tuples' of public static method from exported class has or is using private name 'RecordViewTuple'.
src/directives/ng_for.ts(112,55): error TS4052: Return type of public static method from exported class has or is using private name 'RecordViewTuple'.
src/render/dom/compiler/selector.ts(301,35): error TS4073: Parameter 'map' of public method from exported class has or is using private name 'SelectorContext'.
src/router/path_recognizer.ts(29,20): error TS4073: Parameter 'params' of public method from exported class has or is using private name 'TouchMap'.

These errors should be caught in the build step for angular2.
@tbosch tbosch mentioned this issue Jul 16, 2015
Closed
alexeagle pushed a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@mhegazy @alexeagle
chore(build): Fix .d.ts generation errors caused by invisible types o…
1d5b955 
…f exported declarations

Fixes angular#3098
@alexeagle alexeagle mentioned this issue Jul 17, 2015
Closed
alexeagle pushed a commit to alexeagle/angular that referenced this issue Jul 17, 2015
@mhegazy @alexeagle
chore(build): Fix .d.ts generation errors caused by invisible types o…
d7463b6 
…f exported declarations

Fixes angular#3098
@alexeagle
Copy link
Contributor

I had trouble reproducing this. But @mhegazy is working to change our broccoli build to stop ignoring some TS errors, after which I think we'll have proper enforcement that this doesn't regress.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexeagle alexeagle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(build): Fix .d.ts generation errors caused by invisible types o… alexeagle/angular
2 participants
@alexeagle @uber5001