Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap return values unusable after transform #3309

Closed
yjbanov opened this issue Jul 27, 2015 · 1 comment
Closed

bootstrap return values unusable after transform #3309

yjbanov opened this issue Jul 27, 2015 · 1 comment
Assignees
@yjbanov
Labels
effort2: days type: bug/fix
Milestone
alpha-34

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Jul 27, 2015

The way we rewrite calls to bootstrap makes it impossible to use it with await or even assign the result to a variable.

Example:

ApplicationRef app = await bootstrap(RootComponent, modules);

The transformer rewrites it as:

ApplicationRef app = await ngStaticInit0.initReflector();bootstrapStatic(RootComponent, modules);

This doesn't allow the user to use the app reference.

/cc @TedSander @kegluneq
ref: b/22759297
@yjbanov yjbanov self-assigned this Jul 27, 2015
@yjbanov yjbanov added this to the alpha-34 milestone Jul 27, 2015
yjbanov added a commit to yjbanov/angular that referenced this issue Jul 30, 2015
@yjbanov
fix(bootstrap): fix expressions containing bootstrap (fixes angular#3309
ca6327b 
)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yjbanov yjbanov

Labels
effort2: days type: bug/fix
Projects
None yet
Milestone
alpha-34
Development

No branches or pull requests
2 participants
@mhevery @yjbanov