Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hostActions #3396

Closed
vsavkin opened this issue Jul 30, 2015 · 5 comments
Closed

Remove hostActions #3396

vsavkin opened this issue Jul 30, 2015 · 5 comments
Assignees
@mhevery
Labels
breaking changes effort1: hours refactoring Issue that involves refactoring or code-cleanup
Milestone
alpha-36

Comments

@vsavkin
Copy link
Contributor

vsavkin commented Jul 30, 2015

We should remove hostActions since we agreed that using ElementRef and Renderer directly is a better approach.

This is a breaking change.
@vsavkin vsavkin added effort1: hours refactoring Issue that involves refactoring or code-cleanup comp: core labels Jul 30, 2015
@typotter
Copy link

Without HostActions, what is the recommended way to focus an element?
ElementRef.nativeElement.focus() ?

@mhevery
Copy link
Contributor

mhevery commented Aug 20, 2015

@typotter yes

@0x-r4bbit
Copy link
Contributor

@vsavkin could you quickly summarize why this is the better to deal with that? Performance?

@mhevery mhevery added this to the alpha-36 milestone Aug 25, 2015
@mhevery mhevery self-assigned this Aug 25, 2015
mhevery added a commit to mhevery/angular that referenced this issue Aug 26, 2015
@mhevery
refactor(view): remove hostActions
632c880 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
@mhevery
Copy link
Contributor

mhevery commented Aug 26, 2015

@PascalPrecht It is simpler for the developer. No need to create new concepts. The reason we had actions was to deal with WebWorkes, but CustomRenderer are better solutions there.

mhevery added a commit to mhevery/angular that referenced this issue Aug 26, 2015
@mhevery
refactor(view): remove hostActions
c14e1de 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
mhevery added a commit to mhevery/angular that referenced this issue Aug 26, 2015
@mhevery
refactor(view): remove hostActions
2a2c9e9 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
mhevery added a commit to mhevery/angular that referenced this issue Aug 26, 2015
@mhevery
refactor(view): remove hostActions
f56d55a 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
mhevery added a commit to mhevery/angular that referenced this issue Aug 27, 2015
@mhevery
refactor(view): remove hostActions
4415637 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
mhevery added a commit to mhevery/angular that referenced this issue Aug 27, 2015
@mhevery
refactor(view): remove hostActions
7180c24 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
mhevery added a commit to mhevery/angular that referenced this issue Aug 28, 2015
@mhevery
refactor(view): remove hostActions
12e95ac 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
mhevery added a commit to mhevery/angular that referenced this issue Aug 28, 2015
@mhevery
refactor(view): remove hostActions
45ccd7d 
BREAKING CHANGE

Closes angular#3396

Replacement. Either direct DOM access or Renderer in WebWorkers.
@mccumb01 mccumb01 mentioned this issue Jun 20, 2017
Closed
@manaswinidas manaswinidas mentioned this issue Jun 22, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhevery mhevery

Labels
breaking changes effort1: hours refactoring Issue that involves refactoring or code-cleanup
Projects
None yet
Milestone
alpha-36
Development

No branches or pull requests
4 participants
@vsavkin @mhevery @0x-r4bbit @typotter