Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment creation code broken in 0dbdd5c #3418

Closed
yjbanov opened this issue Jul 31, 2015 · 1 comment
Closed

Fragment creation code broken in 0dbdd5c #3418

yjbanov opened this issue Jul 31, 2015 · 1 comment
Labels
effort1: hours type: bug/fix
Milestone
alpha-34

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Jul 31, 2015

0dbdd5c is faulty.

The following fixes are needed:

  • lib/src/render/dom/util.dart:

    line 82: make list growable:
    ListWrapper.createGrowableSize(fragmentsRootNodeCount[fragmentIndex]);

  • lib/src/render/dom/view/proto_view_merger.dart

    lines 47-49: add marker comment node at the beginning of each fragment
    fragments.skip(1).forEach((nodes) {
    nodes.insert(0, DOM.createComment('|'));
    });

    line 227: make a growable copy of child nodes:
    return DOM.childNodesAsList(DOM.content(fragmentElement)).toList();
@yjbanov yjbanov added this to the alpha-34 milestone Jul 31, 2015
tbosch added a commit to tbosch/angular that referenced this issue Jul 31, 2015
@tbosch
fix(render): allow to configure when templates are serialized to strings
119df5a 
Introduces the injectable `TemplateCloner` that can be configured via the new token `MAX_IN_MEMORY_ELEMENTS_PER_TEMPLATE_TOKEN`.

Also replaces `document.adoptNode` with `document.importNode` as otherwise 
custom elements are not triggered in chrome 43.

Closes angular#3418
@tbosch tbosch mentioned this issue Jul 31, 2015
Closed
tbosch added a commit to tbosch/angular that referenced this issue Jul 31, 2015
@tbosch
fix(render): allow to configure when templates are serialized to strings
d658620 
Introduces the injectable `TemplateCloner` that can be configured via the new token `MAX_IN_MEMORY_ELEMENTS_PER_TEMPLATE_TOKEN`.

Also replaces `document.adoptNode` with `document.importNode` as otherwise 
custom elements are not triggered in chrome 43.

Closes angular#3418
tbosch added a commit to tbosch/angular that referenced this issue Jul 31, 2015
@tbosch
fix(render): allow to configure when templates are serialized to strings
5c7b79f 
Introduces the injectable `TemplateCloner` that can be configured via the new token `MAX_IN_MEMORY_ELEMENTS_PER_TEMPLATE_TOKEN`.

Also replaces `document.adoptNode` with `document.importNode` as otherwise 
custom elements are not triggered in chrome 43.

Closes angular#3418
@tbosch tbosch closed this as completed in dd06a87 Jul 31, 2015
stevemao pushed a commit to stevemao/angular that referenced this issue Aug 3, 2015
@tbosch
fix(render): allow to configure when templates are serialized to strings
1371128 
Introduces the injectable `TemplateCloner` that can be configured via the new token `MAX_IN_MEMORY_ELEMENTS_PER_TEMPLATE_TOKEN`.

Also replaces `document.adoptNode` with `document.importNode` as otherwise
custom elements are not triggered in chrome 43.

Closes angular#3418
Closes angular#3433
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort1: hours type: bug/fix
Projects
None yet
Milestone
alpha-34
Development

Successfully merging a pull request may close this issue.

fix(render): allow to configure when templates are serialized to strings tbosch/angular
2 participants
@yjbanov @tbosch