Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Testing section: component-class-testing, a little mistake #36155

Closed
Fouzyyyy opened this issue Mar 20, 2020 · 3 comments
Closed

Docs: Testing section: component-class-testing, a little mistake #36155

Fouzyyyy opened this issue Mar 20, 2020 · 3 comments
Milestone
needsTriage

Comments

@Fouzyyyy
Copy link
Contributor

Fouzyyyy commented Mar 20, 2020 •
edited

馃摎 Docs or angular.io bug report

Description

There is a misleading sentence in the component class testing section, precisely the following sentence: This component class has no dependencies. To test a service with no dependencies, you create it...

Here, we jump from testing a component to testing a service.

馃敩 Minimal Reproduction

This can be checked here: https://angular.io/guide/testing#component-class-testing

What's the affected URL?**

https://angular.io/guide/testing#component-class-testing

Reproduction Steps**

Expected vs Actual Behavior**

馃摲Screenshot

馃敟 Exception or Error

馃實 Your Environment

Browser info

Anything else relevant?
@Fouzyyyy
Copy link
Contributor Author

I can submit a MR to fix this.

@Fouzyyyy Fouzyyyy changed the title Testing section: component-class-testing Docs: Testing section: component-class-testing, a little mistake Mar 20, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 20, 2020
@sonukapoor
Copy link
Contributor

@Fouzyyyy Go for it. Let us know if you need any help.

@Fouzyyyy Fouzyyyy mentioned this issue Mar 20, 2020
Closed
14 tasks
@alxhub alxhub closed this as completed in bfa7b1a Mar 27, 2020
alxhub pushed a commit that referenced this issue Mar 27, 2020
@Fouzyyyy @alxhub
docs: correct a misleading sentence (#36155) (#36158)
0cb3c04 
Fixes #36155

PR Close #36158
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

docs: fix a misleading sentence in component class testing section
3 participants
@sonukapoor @pkozlowski-opensource @Fouzyyyy