Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(core): change development mode console message #36570

Closed
michielkikkert opened this issue Apr 10, 2020 · 2 comments
Closed

style(core): change development mode console message #36570

michielkikkert opened this issue Apr 10, 2020 · 2 comments
Labels
area: core Issues related to the framework runtime core: debug tools
Milestone
needsTriage

Comments

@michielkikkert
Copy link
Contributor

The message can be improved by removing the unneeded ‘the’ (x2).

Before:
Angular is running in the development mode. Call enableProdMode() to enable the production mode.

After:
Angular is running in development mode. Call enableProdMode() to enable production mode.

I will do a PR for this issue shortly.
michielkikkert added a commit to michielkikkert/angular that referenced this issue Apr 10, 2020
@michielkikkert
style(core): change development mode console message
d51c233 
The message can be improved by removing the unneeded ‘the’ (x2).

Before:
Angular is running in the development mode. Call enableProdMode() to enable the production mode.

After:
Angular is running in development mode. Call enableProdMode() to enable production mode.

Closes angular#36570
@michielkikkert michielkikkert mentioned this issue Apr 10, 2020
Closed
12 tasks
@pkozlowski-opensource pkozlowski-opensource added area: core Issues related to the framework runtime core: debug tools labels Apr 11, 2020
@ngbot ngbot bot modified the milestone: needsTriage Apr 11, 2020
@Achilles1515
Copy link

I've always thought it would be nice to include which rendering engine is in use. Something like:

Angular is running in development mode with Ivy enabled. Call enableProdMode() to enable production mode.

michielkikkert added a commit to michielkikkert/angular that referenced this issue Apr 30, 2020
@michielkikkert
style(core): change development mode console message
8386472 
The message can be improved by removing the unneeded ‘the’ (x2).

Before:
Angular is running in the development mode. Call enableProdMode() to enable the production mode.

After:
Angular is running in development mode. Call enableProdMode() to enable production mode.

Closes angular#36570
IgorMinar pushed a commit to michielkikkert/angular that referenced this issue May 12, 2020
@michielkikkert @IgorMinar
fix(core): correct "development mode" console message
6ed747d 
The message can be improved by removing the unneeded ‘the’ (x2).

Before:
Angular is running in the development mode. Call enableProdMode() to enable the production mode.

After:
Angular is running in development mode. Call enableProdMode() to enable production mode.

Closes angular#36570
IgorMinar pushed a commit to michielkikkert/angular that referenced this issue May 12, 2020
@michielkikkert @IgorMinar
fix(core): correct "development mode" console message
4173622 
The message can be improved by removing the unneeded ‘the’ (x2).

Before:
Angular is running in the development mode. Call enableProdMode() to enable the production mode.

After:
Angular is running in development mode. Call enableProdMode() to enable production mode.

Closes angular#36570
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 12, 2020
profanis pushed a commit to profanis/angular that referenced this issue Sep 5, 2020
@michielkikkert @profanis
fix(core): correct "development mode" console message (angular#36571)
72345b5 
The message can be improved by removing the unneeded ‘the’ (x2).

Before:
Angular is running in the development mode. Call enableProdMode() to enable the production mode.

After:
Angular is running in development mode. Call enableProdMode() to enable production mode.

Closes angular#36570

PR Close angular#36571
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: core Issues related to the framework runtime core: debug tools
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(core): correct "development mode" console message michielkikkert/angular
3 participants
@michielkikkert @pkozlowski-opensource @Achilles1515