Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformer does not handle const instance annotations on properties. #4481

Closed
kegluneq opened this issue Oct 2, 2015 · 1 comment
Closed

Transformer does not handle const instance annotations on properties. #4481

kegluneq opened this issue Oct 2, 2015 · 1 comment
Assignees
@kegluneq
Labels
effort1: hours type: bug/fix

Comments

@kegluneq
Copy link

kegluneq commented Oct 2, 2015

For example:

@Component(...)
@View(...)
class MyComponent implements MyFieldGetter {
  @override
  String get myField => 'Yeah!';
}

Registers the annotation as:

const [const override()]

Rather than

const [override]
@kegluneq kegluneq self-assigned this Oct 2, 2015
kegluneq pushed a commit to kegluneq/angular that referenced this issue Oct 2, 2015
fix(dart/transformer): Correctly handle const object annotations
0b2b326 
Previously, annotations which were const objects (as opposed to const
instance creation expressions) were incorrectly output as instance
creation expressions.

Before:
```
const override() // A const instance creation expression
```

After
```
override // A const instance
```

Closes angular#4481
@kegluneq kegluneq mentioned this issue Oct 2, 2015
Closed
kegluneq pushed a commit to kegluneq/angular that referenced this issue Oct 3, 2015
fix(dart/transformer): Correctly handle const object annotations
99813b7 
Previously, annotations which were const objects (as opposed to const
instance creation expressions) were incorrectly output as instance
creation expressions.

Before:
```
const override() // A const instance creation expression
```

After
```
override // A const instance
```

Closes angular#4481
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kegluneq kegluneq

Labels
effort1: hours type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dart/transformer): Correctly handle const object annotations kegluneq/angular
1 participant
@kegluneq