Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response ok is sometimes undefined #6390

Closed
oliverjanik opened this issue Jan 11, 2016 · 3 comments
Closed

Response ok is sometimes undefined #6390

oliverjanik opened this issue Jan 11, 2016 · 3 comments

Comments

@oliverjanik
Copy link

I'm doing this

        return this.http.request(request)
            .map(res => {
                if (!res.ok) {
                    console.error(res.ok);
                    console.error(res.status);
                }

                return res.json();
            });

And some calls report status 200 and ok is undefined:

image
@pkozlowski-opensource
Copy link
Member

@oliverjanik it is impossible to investigate / help based on the provided info. If you need further assistance please provide a live reproduce scenario using plunker or similar.

@oliverjanik
Copy link
Author

Response.ok should be true when status is 200-299, correct? I'm getting undefined.

Looking briefly at the code here:

The ok property is never assigned to.

@Utsav2 Utsav2 mentioned this issue Jan 15, 2016
Closed
Utsav2 added a commit to Utsav2/angular that referenced this issue Jan 15, 2016
@Utsav2
fix(http): Set response.ok
86d6641 
The ok property was not being set on response objects.
It's now set based on the status code.

Fixes angular#6390
Utsav2 added a commit to Utsav2/angular that referenced this issue Jan 15, 2016
@Utsav2
fix(http): Set response.ok
a5b0d5d 
The ok property was not being set on response objects.
It's now set based on the status code.

Closes angular#6390
@user414 user414 mentioned this issue Feb 9, 2016
Closed
@oliverjanik oliverjanik mentioned this issue Apr 15, 2016
Closed
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this issue Jun 21, 2016
@Utsav2 @KiaraGrouwstra
fix(http): Set response.ok
5dce29c 
The ok property was not being set on response objects.
It's now set based on the status code.

Closes angular#6390
Closes angular#6503
hbkrunal pushed a commit to hbkrunal/angular that referenced this issue Sep 15, 2016
@Utsav2 @mhevery
fix(http): Set response.ok
021460b 
The ok property was not being set on response objects.
It's now set based on the status code.

Closes angular#6390
Closes angular#6503
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set response.ok Utsav2/angular
2 participants
@pkozlowski-opensource @oliverjanik