Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NgUpgrade Uncaught TypeError: Cannot read property 'BROWSER_APP_COMPILER_PROVIDERS' of undefined #9244

Closed
albertosantini opened this issue Jun 16, 2016 · 4 comments
Closed

NgUpgrade Uncaught TypeError: Cannot read property 'BROWSER_APP_COMPILER_PROVIDERS' of undefined #9244

albertosantini opened this issue Jun 16, 2016 · 4 comments
Assignees
@IgorMinar
Milestone
2.0.0-rc.3

Comments

@albertosantini
Copy link
Contributor

albertosantini commented Jun 16, 2016 •
edited

When the adapter is bootstrapped, I get the message in the subject.

upgradeAdapter.bootstrap(document.body, ["dummy"]);

This is due to the wrong object injected to upgrade.umd.js when it is loaded: global.ng.platformBrowser.dynamic instead of global.ng.platformBrowserDynamic.

As workaround

        <script>ng.platformBrowser.dynamic = ng.platformBrowserDynamic;</script>
        <script src="node_modules/@angular/upgrade/bundles/upgrade.umd.js"></script>

https://github.com/albertosantini/angular2-es5-jumpstart/blob/master/src/client/app/mix-ng1-ng2.js
https://github.com/albertosantini/angular2-es5-jumpstart/blob/master/src/client/index.html#L33

Edit: This is in 2.0.0-rc.2. In 2.0.0-rc.1 it was ok.
@IgorMinar
Copy link
Contributor

thanks for the report. we'll fix this in rc.3

@IgorMinar IgorMinar added this to the 2.0.0-rc.3 milestone Jun 16, 2016
@IgorMinar
Copy link
Contributor

IgorMinar commented Jun 16, 2016 •
edited

  • the rollup.config.json is incorrect for the upgrade package
  • the upgrade example is broken due to loader misconfiguration
  • the e2e test for the upgrade example is missing for some reason (that's why we didn't catch this on our CI)

@IgorMinar IgorMinar self-assigned this Jun 16, 2016
@naomiblack naomiblack modified the milestones: 2.0.0-rc.3, 2.0.0-rc.4 Jun 21, 2016
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jun 21, 2016
@IgorMinar
fix(upgrade): fix bundling issue and fix e2e test
f39c664 
the previous demo app was broken and is missing an e2e test.

I fixed the app, but was not able to get protractor to properly test
this app. Julie and I are looking into that. For now I manually verified
that the app works and that the original issue was fixed.

Closes angular#9244
@IgorMinar IgorMinar mentioned this issue Jun 21, 2016
Closed
@albertosantini
Copy link
Contributor Author

Tested with rc.3 in my use case. It works nice.
Thanks for the quick fix.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@IgorMinar IgorMinar

Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.3
Development

Successfully merging a pull request may close this issue.

fix(upgrade): fix bundling issue and fix e2e test IgorMinar/angular
4 participants
@IgorMinar @albertosantini @pkozlowski-opensource @naomiblack