Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$query and $ref proposal #858

Closed
cartant opened this issue Mar 16, 2017 · 1 comment
Closed

$query and $ref proposal #858

cartant opened this issue Mar 16, 2017 · 1 comment

Comments

@cartant
Copy link
Contributor

cartant commented Mar 16, 2017

I have a minor proposal re: the release candidate proposal in #854.

Currently, the FirebaseListObservable and the FirebaseObjectObservable both have a $ref property that refers to the underlying SDK object. However, with the FirebaseListObservable, $ref refers to a Query. Which means that if you want to access the Reference you have to use list.$ref.ref.

This is something that I find a little annoying, but I can live with it. However, given that the intention is for the RC to encourage concurrent use of AngularFire(2) and the SDK, wouldn't it be better to make this more explicit and add separate $query and $ref properties to the FirebaseListObservable? Or to use a $query property instead of a $ref property for the FirebaseListObservable?

@cartant cartant closed this as completed Mar 16, 2017
@cartant
Copy link
Contributor Author

cartant commented Mar 16, 2017

Never mind. I had this wrong. With FirebasListObservable the type of the $ref property is Reference | Query and what it is depends upon what's passed into the factory. It's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant