Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): use onAuthStateChanged for authState #2308

Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix(auth): use onAuthStateChanged for authState #2308

merged 1 commit into from
Feb 5, 2020

Conversation

sarunint
Copy link
Contributor

@sarunint sarunint commented Feb 3, 2020 •
edited
Loading

Checklist

Description

This fixes #2307 where AngularFireAuth.authState incorrectly uses auth.onIdTokenChanged.

Code sample

None

@sarunint sarunint closed this Feb 3, 2020
@sarunint sarunint reopened this Feb 3, 2020
jamesdaniels
jamesdaniels approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jamesdaniels jamesdaniels merged commit 9506f85 into angular:v5 Feb 5, 2020
@jamesdaniels
Copy link
Member

I'll cut 5.4.1 shortly

@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarunint @jamesdaniels @googlebot