Skip to content

Commit

Permalink
fix: google-maps and youtube-player package missing tslib dependency (#…
Browse files Browse the repository at this point in the history
…17939)

* build: use placeholder for tslib version

* fix: google-maps and youtube-player package missing tslib dependency

The google-maps and youtube-player package currently do not have
`tslib` listed as dependency while TypeScript helper's are enabled
and used in these packages.
  • Loading branch information
devversion authored and mmalerba committed Dec 11, 2019
1 parent 6ae74a0 commit 2a2d837
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 7 deletions.
3 changes: 3 additions & 0 deletions packages.bzl
Expand Up @@ -3,9 +3,12 @@
# version for the placeholders.
ANGULAR_PACKAGE_VERSION = "^9.0.0-0 || ^10.0.0-0"
MDC_PACKAGE_VERSION = "^4.0.0"
TSLIB_PACKAGE_VERSION = "^1.9.0"

VERSION_PLACEHOLDER_REPLACEMENTS = {
"0.0.0-MDC": MDC_PACKAGE_VERSION,
"0.0.0-NG": ANGULAR_PACKAGE_VERSION,
"0.0.0-TSLIB": TSLIB_PACKAGE_VERSION,
}

# List of default Angular library UMD bundles which are not processed by ngcc.
Expand Down
2 changes: 1 addition & 1 deletion src/cdk-experimental/package.json
Expand Up @@ -22,7 +22,7 @@
"peerDependencies": {
"@angular/cdk": "0.0.0-PLACEHOLDER",
"@angular/core": "0.0.0-NG",
"tslib": "^1.9.0"
"tslib": "0.0.0-TSLIB"
},
"sideEffects": false,
"publishConfig":{
Expand Down
2 changes: 1 addition & 1 deletion src/cdk/package.json
Expand Up @@ -29,7 +29,7 @@
"peerDependencies": {
"@angular/core": "0.0.0-NG",
"@angular/common": "0.0.0-NG",
"tslib": "^1.9.0"
"tslib": "0.0.0-TSLIB"
},
"optionalDependencies": {
"parse5": "^5.0.0"
Expand Down
3 changes: 2 additions & 1 deletion src/google-maps/package.json
Expand Up @@ -25,7 +25,8 @@
},
"homepage": "https://github.com/angular/components/tree/master/src/google-maps#readme",
"dependencies": {
"@types/googlemaps": "^3.37.0"
"@types/googlemaps": "^3.37.0",
"tslib": "0.0.0-TSLIB"
},
"peerDependencies": {
"@angular/core": "0.0.0-NG",
Expand Down
2 changes: 1 addition & 1 deletion src/material-experimental/package.json
Expand Up @@ -23,7 +23,7 @@
"@angular/core": "0.0.0-NG",
"@angular/material": "0.0.0-PLACEHOLDER",
"material-components-web": "0.0.0-MDC",
"tslib": "^1.9.0"
"tslib": "0.0.0-TSLIB"
},
"sideEffects": false,
"publishConfig":{
Expand Down
2 changes: 1 addition & 1 deletion src/material-moment-adapter/package.json
Expand Up @@ -23,7 +23,7 @@
"@angular/material": "0.0.0-PLACEHOLDER",
"@angular/core": "0.0.0-NG",
"moment": "^2.18.1",
"tslib": "^1.9.0"
"tslib": "0.0.0-TSLIB"
},
"ng-update": {
"packageGroup": [
Expand Down
2 changes: 1 addition & 1 deletion src/material/package.json
Expand Up @@ -31,7 +31,7 @@
"@angular/core": "0.0.0-NG",
"@angular/common": "0.0.0-NG",
"@angular/forms": "0.0.0-NG",
"tslib": "^1.9.0"
"tslib": "0.0.0-TSLIB"
},
"schematics": "./schematics/collection.json",
"ng-update": {
Expand Down
3 changes: 2 additions & 1 deletion src/youtube-player/package.json
Expand Up @@ -25,7 +25,8 @@
},
"homepage": "https://github.com/angular/components/tree/master/src/youtube-player#readme",
"dependencies": {
"@types/youtube": "^0.0.38"
"@types/youtube": "^0.0.38",
"tslib": "0.0.0-TSLIB"
},
"peerDependencies": {
"@angular/core": "0.0.0-NG",
Expand Down

0 comments on commit 2a2d837

Please sign in to comment.