Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(cdk/overlay): fix wrong overflow calculation (#17791)
* fix(cdk/overlay): fix wrong overflow calculation overflowBottom is currently calculated with viewport.bottom (which could be any number from the height of the viewport to as large as your page is) calculating the overflow should just be difference between "overlay.height added to the current coordinate on the overlay container" and the height of the viewport, not the height of the entire page. * fix(popover-edit): fix failing test Tested component should always fit within the viewport. Pane dimensions should be approximately compared. * avoid flaky errors due to narrow viewport width Co-authored-by: Gobius Dolhain <Goobles@users.noreply.github.com> Co-authored-by: Andrew Seguin <andrewjs@google.com>
- Loading branch information
1 parent
df7156e
commit d2b499d
Showing
2 changed files
with
15 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters