Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't import overlay.scss #1123

Closed
FabioAntunes opened this issue Aug 25, 2016 · 7 comments
Closed

Can't import overlay.scss #1123

FabioAntunes opened this issue Aug 25, 2016 · 7 comments

Comments

@FabioAntunes
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Be able to import @angular2-material/core/overlay/overlay

What is the current behavior?

Module build failed: 
@import 'variables';
^
      File to import not found or unreadable: variables
Parent style sheet: /home/fabio/playground/angular2-scaffolding/node_modules/@angular2-material/core/overlay/overlay.scss
      in /home/fabio/playground/angular2-scaffolding/node_modules/@angular2-material/core/overlay/overlay.scss (line 3, column 1)

What are the steps to reproduce?

Just import overlay into your scss file:

@import '~@angular2-material/core/style/core';
@import '~@angular2-material/core/overlay/overlay';

Which versions of Angular, Material, OS, browsers are affected?

2.0.0-alpha.7-4

@RoxKilly
Copy link

I think that core and overlay styles should not be imported into your components, but rather linked to in your index.html

<link rel="stylesheet" href="path/to/core.css">
<link rel="stylesheet" href="path/to/overlay.css">

See: #972 (comment)

@FabioAntunes
Copy link
Author

@RoxKilly I'm importing those to my index.scss, not my components and I fact you can import those css files, into your root component if you disable the ViewEncapsulation. The issue here is that the scss file is not valid, it's trying to import the variables file, when there's no file to import

@spock123
Copy link

@FabioAntunes don't load the overlay.scss file, load the overlay.css file.....

@spock123
Copy link

Also, forget about importing the file.

Just include the two css rules in your own styles

@vapits
Copy link

vapits commented Sep 3, 2016

Same here, I cannot imnport it nowhere, index.html or styleurls. I'm getting 404 even that the file is there

@jelbourn
Copy link
Member

Obsolete by theming update.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants