Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Inverted md-tabs style #1362

Closed
anderflash opened this issue Sep 29, 2016 · 2 comments · Fixed by #5287
Closed

[Tabs] Inverted md-tabs style #1362

anderflash opened this issue Sep 29, 2016 · 2 comments · Fixed by #5287
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@anderflash
Copy link

Bug, feature request, or proposal:

Feature enhancement

What is the expected behavior?

I would like tabs with same background as toolbar when they are next to each other. We could switch background and color properties (it could be a new md-tabs property). You see this style in Google Material Design.

What is the current behavior?

Now md-tabs just has the option of change color (which changes text color and ink bar), instead of setting the background.

What are the steps to reproduce?

Not applicable

What is the use-case or motivation for changing an existing behavior?

More consistency between toolbar and tabs. Developer might choose between light (text color) and dark (background color) versions.

Which versions of Angular, Material, OS, browsers are affected?

Latest

Is there anything else we should know?

Just a reverse-style="true" attribute might work well.

@andrewseguin andrewseguin self-assigned this Nov 3, 2016
@andrewseguin andrewseguin added the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label Nov 16, 2016
@andrewseguin andrewseguin changed the title Inverted md-tabs style [Tabs] Inverted md-tabs style Nov 16, 2016
@andrewseguin andrewseguin added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Feb 23, 2017
@willshowell
Copy link
Contributor

@andrewseguin thoughts on an API like this?

<md-tab-group color="accent" background="primary">
  <md-tab label="Tab 1">Content 1</md-tab>
  <md-tab label="Tab 2">Content 2</md-tab>
</md-tab-group>

[color] set the inkbar and active tab-label color
[background] sets the tab-header color

When [background] is used, the tab-label color is overriden to be white

Related to #2908

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants