fix(tabs): focusChange not being emitted when tabbing into a tab header #15094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
14142/tabs-focus-change-initial
branch
from
c7457b1
to
124e72a
Compare
crisbeto
force-pushed
the
14142/tabs-focus-change-initial
branch
from
124e72a
to
351b4f1
Compare
andrewseguin
added
the
P3
crisbeto
force-pushed
the
14142/tabs-focus-change-initial
branch
from
351b4f1
to
af8625a
Compare
crisbeto
force-pushed
the
14142/tabs-focus-change-initial
branch
from
af8625a
to
cf5830f
Compare
Fixes the `focusChange` output not emitting when the user tabs into a tab header which is different from the previously-focused one. Fixes angular#14142.
crisbeto
force-pushed
the
14142/tabs-focus-change-initial
branch
from
cf5830f
to
9745fa2
Compare
andrewseguin
approved these changes
Jun 15, 2020
andrewseguin
added
lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
focusChangeoutput not emitting when the user tabs into a tab header which is different from the previously-focused one.Fixes #14142.