Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TSLint rule to prevent usage of params for animations #15306

Open
josephperrott opened this issue Feb 25, 2019 · 2 comments
Open

Create TSLint rule to prevent usage of params for animations #15306

josephperrott opened this issue Feb 25, 2019 · 2 comments
Labels
animation This issue is related to Angular animations or CSS animations area: many Area label for issues related to many components G This is is related to a Google internal issue P4 A relatively minor issue that is not relevant to core functions

Comments

@josephperrott
Copy link
Member

Create TSLint rule to prevent usage of params for animations. The intention is for this lint rule to be in place to require us to explicitly state why we want to use the param and ensure we declare the accompanying const for the parameter being used.
@josephperrott josephperrott added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue labels Feb 25, 2019
@devversion
Copy link
Member

Does that mean we want a lint rule that always prevents the usage of params for animations.. and if we want to use them, we need to explicitly disable the lint rule?

@josephperrott
Copy link
Member Author

Yes, it is needed because we don't have a way for us to inform closure compiler internally that the property should not be obfuscated.

@andrewseguin andrewseguin added animation This issue is related to Angular animations or CSS animations area: many Area label for issues related to many components labels Jun 12, 2020
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions and removed P2 The issue is important to a large percentage of users, with a workaround labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
animation This issue is related to Angular animations or CSS animations area: many Area label for issues related to many components G This is is related to a Google internal issue P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crisbeto @devversion @josephperrott @andrewseguin