Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): able to remove disabled chip via remove button #15732

Merged
merged 1 commit into from May 14, 2019
Merged

fix(chips): able to remove disabled chip via remove button #15732

merged 1 commit into from May 14, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 5, 2019

Fixes users being able to remove disabled chips by clicking on their remove button.

Fixes #15708.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 5, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner April 5, 2019 15:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 5, 2019
jelbourn
jelbourn approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 8, 2019
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@jelbourn
Copy link
Member

@crisbeto I have this passing now if you can rebase

@crisbeto
fix(chips): able to remove disabled chip via remove button
856d32a 
Fixes users being able to remove disabled chips by clicking on their remove button.

Fixes angular#15708.
@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto force-pushed the 15708/disabled-chip-remove branch from 084be9e to 856d32a Compare May 14, 2019 16:17
@jelbourn jelbourn merged commit 20a0930 into angular:master May 14, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
fix(chips): able to remove disabled chip via remove button (angular#1…
2bb02ea 
…5732)

Fixes users being able to remove disabled chips by clicking on their remove button.

Fixes angular#15708.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled mat-chip still removable
4 participants
@crisbeto @jelbourn @googlebot @mmalerba