fix(material): fix table generator schematic #16204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Are there tests for schematics? |
josephperrott
added
the
target: patch
jelbourn
reviewed
Jun 5, 2019
.../ng-generate/table/files/__path__/__name@dasherize@if-flat__/__name@dasherize__.component.ts
Outdated
Show resolved
Hide resolved
|
I removed the |
|
I think we should specify static false explicitly. So that the generated components can easily migrate to version 9 of Angular eventually. Sorry for the confusion. |
josephperrott
removed
the
action: merge
Import `MatTable` (used in `ViewChild` query). Add `static` option to view queries for future support of Angular version 9.
|
That should do it, Paul ☀ |
devversion
approved these changes
Jun 6, 2019
josephperrott
pushed a commit
that referenced
this pull request
Jun 10, 2019
Import `MatTable` (used in `ViewChild` query). Add `static` option to view queries for future support of Angular version 9.
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
Import `MatTable` (used in `ViewChild` query). Add `static` option to view queries for future support of Angular version 9.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import
MatTable(used inViewChildquery).Add
staticoption to view queries for future support of Angular version 9.