Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): events not being unbound from destroyed backdrop #16268

Merged
merged 1 commit into from Jun 26, 2019
Merged

fix(overlay): events not being unbound from destroyed backdrop #16268

merged 1 commit into from Jun 26, 2019

Conversation

crisbeto
Copy link
Member

Fixes the click and transitionend event handlers not being removed from the backdrop that is being destroyed. Since they're referring to things inside the OverlayRef, they could cause some memory to be retained.

@crisbeto
fix(overlay): events not being unbound from destroyed backdrop
8932866 
Fixes the `click` and `transitionend` event handlers not being removed from the backdrop that is being destroyed. Since they're referring to things inside the `OverlayRef`, they could cause some memory to be retained.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 11, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner June 11, 2019 15:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2019
jelbourn
jelbourn approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 11, 2019
@andrewseguin andrewseguin merged commit 453b1e8 into angular:master Jun 26, 2019
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@crisbeto @andrewseguin
fix(overlay): events not being unbound from destroyed backdrop (#16268)
c0efe17 
Fixes the `click` and `transitionend` event handlers not being removed from the backdrop that is being destroyed. Since they're referring to things inside the `OverlayRef`, they could cause some memory to be retained.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin