Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expansion): not adding margin for all button types #16806

Merged
merged 1 commit into from Aug 21, 2019
Merged

fix(expansion): not adding margin for all button types #16806

merged 1 commit into from Aug 21, 2019

Conversation

crisbeto
Copy link
Member

Currently the margins for buttons inside the mat-action-row is only set up for mat-button, however we have other variants like raised and stroked buttons which haven't been accounted for.

@crisbeto
fix(expansion): not adding margin for all button types
af8f239 
Currently the margins for buttons inside the `mat-action-row` is only set up for `mat-button`, however we have other variants like raised and stroked buttons which haven't been accounted for.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 18, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 18, 2019
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 19, 2019
@andrewseguin andrewseguin merged commit 6a21d94 into angular:master Aug 21, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
@crisbeto @andrewseguin
fix(expansion): not adding margin for all button types (#16806)
1d545a6 
Currently the margins for buttons inside the `mat-action-row` is only set up for `mat-button`, however we have other variants like raised and stroked buttons which haven't been accounted for.

(cherry picked from commit 6a21d94)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @josephperrott @googlebot @andrewseguin