fix(stepper): remove tabindex from content #16809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
16692/stepper-content-tabindex
branch
from
bfa4022
to
576f8bf
Compare
crisbeto
force-pushed
the
16692/stepper-content-tabindex
branch
from
576f8bf
to
cbbd31f
Compare
crisbeto
force-pushed
the
16692/stepper-content-tabindex
branch
from
cbbd31f
to
a8e6cf8
Compare
crisbeto
force-pushed
the
16692/stepper-content-tabindex
branch
from
a8e6cf8
to
ac4203d
Compare
|
looks like there's some test failures |
A while ago in angular#14892 we added a `tabindex` to the content of the current step, however since then we consulted with the a11y team and it looks like adding the `tabindex` there isn't the best approach. Fixes angular#16692.
crisbeto
force-pushed
the
16692/stepper-content-tabindex
branch
from
ac4203d
to
248c651
Compare
|
I've fixed the test failures. |
|
Would be awesome to see it merged |
jelbourn
added
P2
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago in #14892 we added a
tabindexto the content of the current step based on a recommendation from W3C a11y guidelines, however since then we consulted with the a11y team and it looks like adding thetabindexthere isn't the best approach.Fixes #16692.