fix(tabs): unnecessarily adding pagination when changing to new list of tabs with same labels #16869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
…of tabs with same labels These changes fix an issue where swapping out the list of tabs to one with the same labels causes the header to add a pagination when it doesn't have to. It looks like issue comes down to the fact that we check the element dimensions before they've had the chance to update. This works for the case where the tabs have different text, because we also have a `MutationObserver` that looks at them and it fires a bit later. Fixes angular#16789.
crisbeto
force-pushed
the
16789/tabs-pagination-same-text
branch
from
90b2436
to
5685918
Compare
jelbourn
pushed a commit
that referenced
this pull request
Apr 24, 2020
…of tabs with same labels (#16869) These changes fix an issue where swapping out the list of tabs to one with the same labels causes the header to add a pagination when it doesn't have to. It looks like issue comes down to the fact that we check the element dimensions before they've had the chance to update. This works for the case where the tabs have different text, because we also have a `MutationObserver` that looks at them and it fires a bit later. Fixes #16789.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 24, 2020
Recently angular#16869 was merged which was created before we had MDC-based tabs which means that the MDC tests were never updated.
jelbourn
pushed a commit
that referenced
this pull request
Apr 24, 2020
Recently #16869 was merged which was created before we had MDC-based tabs which means that the MDC tests were never updated.
jelbourn
pushed a commit
that referenced
this pull request
Apr 24, 2020
Recently #16869 was merged which was created before we had MDC-based tabs which means that the MDC tests were never updated.
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…of tabs with same labels (angular#16869) These changes fix an issue where swapping out the list of tabs to one with the same labels causes the header to add a pagination when it doesn't have to. It looks like issue comes down to the fact that we check the element dimensions before they've had the chance to update. This works for the case where the tabs have different text, because we also have a `MutationObserver` that looks at them and it fires a bit later. Fixes angular#16789.
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
Recently angular#16869 was merged which was created before we had MDC-based tabs which means that the MDC tests were never updated.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix an issue where swapping out the list of tabs to one with the same labels causes the header to add a pagination when it doesn't have to. It looks like issue comes down to the fact that we check the element dimensions before they've had the chance to update. This works for the case where the tabs have different text, because we also have a
MutationObserverthat looks at them and it fires a bit later.Fixes #16789.