feat(clipboard): add the ability to specify number of attempts in clipboard directive #17547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 31, 2019
crisbeto
force-pushed
the
clipboard-directive-attempts
branch
from
6d4dbe3
to
30a9da5
Compare
|
Added an injection token that can be used to configure the number of attempts. |
jelbourn
approved these changes
Oct 31, 2019
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
clipboard-directive-attempts
branch
from
30a9da5
to
0a307d8
Compare
|
good to merge after rebasing and fixing the lint error |
crisbeto
force-pushed
the
clipboard-directive-attempts
branch
from
0a307d8
to
ff4a67a
Compare
|
Done @mmalerba. |
|
It looks like there is an issue with the tests now |
…pboard directive Adds a new input to the `cdkCopyToClipboard` directive which allows consumers to set the number of attempts to try and copy their text. We currently have an example of how to implement attempts in the readme, but this feature makes it more convenient so that consumers don't have to do it on a case-by-case basis.
crisbeto
force-pushed
the
clipboard-directive-attempts
branch
from
ff4a67a
to
e158d47
Compare
|
Looks like I messed up the rebase. It should be good to go now. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new input to the
cdkCopyToClipboarddirective which allows consumers to set the number of attempts to try and copy their text. We currently have an example of how to implement attempts in the readme, but this feature makes it more convenient so that consumers don't have to do it on a case-by-case basis.