fix(google-maps): avoid event listener leaks if inputs change #17664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we initialize the map-related event listeners inside a subscription in the various map components, however the only time we remove them is on destroy. This can lead to leaks if the subcription fires multiple times. Note that at the moment we have a guard in place in the form of `take(1)`, but we could easily end up with event leaks if it were to be moved/removed if we decided to make it to react to changes post initialization.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we initialize the map-related event listeners inside a subscription in the various map components, however the only time we remove them is on destroy. This can lead to leaks if the subcription fires multiple times. Note that at the moment we have a guard in place in the form of
take(1), but we could easily end up with event leaks if it were to be moved/removed if we decided to make it to react to changes post initialization.