fix(ng-update): imports to MatProgressSpinnerModule not migrated
#17717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For v9 we generated a mapping of symbols and their corresponding secondary entry-points. This map was based on the public API goldens we generate with ts-api-guardian. Unfortunately ts-api-guardian has known limitations with aliased exports which do not have the export keyword on the actual declaration. This means that we currently do not have a mapping for such exports. Temporarily changing ts-api-guardian to handle such cases showed that the progress-bar module is the only instance in the project. Fixes angular#17715.
devversion
added
P1
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For v9 we generated a mapping of symbols and their corresponding secondary
entry-points. This map was based on the public API goldens we generate with
ts-api-guardian. Unfortunately ts-api-guardian has known limitations with
aliased exports which do not have the export keyword on the actual declaration.
This means that we currently do not have a mapping for such exports. Temporarily
changing ts-api-guardian to handle such cases showed that the progress-bar
module is the only instance in the project.
Fixes #17715.
Note: This actually brings us to the point where we should re-consider the effort of switching to api-extractor from Microsoft eventually. This was already planned in the past, but we prioritized other things IIRC. The current API goldens are not guaranteed to be complete.